search

simtr / PowderToypp

This repository has been moved to https://github.com/FacialTurd/The-Powder-Toy
https://github.com/FacialTurd/The-Powder-Toy
GNU General Public License v3.0
20 stars 12 forks source link

Missed commits #160

Closed jacob1 closed 12 years ago

jacob1 commented 12 years ago

I noticed a few commits were missed when porting them from tpt

acid doesn't eat BGLA save more things in powder.pref - Debug mode, and gravity things need to be saved. The sponge/gel absorbing water ones (I think these were commited after you last added tpt stuff) ... I guess some I thought were missed were actually put in, so this list is smaller than I thought.

These were never given a yes/no answer, if they weren't merged because of some mistakes I made on that pull request, maybe it can just be moved over to tpt++ in one piece now.

nice WOOD and PLNT graphical effects (also has second part) LIGH fix (make it useful again) DTEC, I made this because you said you wanted it Fix things melting with heat sim off that shouldn't. Also, move INSL to electronics where it belongs simple cold PHOTons fix fix H2/O2 not burning, this fixes the commit Triclops200 made and fixes PHOT colors to make them how the original creator wanted (I didn't realize PHOT had a weird color format back then) Black deco on save thumbnails Add another use to tpt.element, so you don't need to create a large array or loop through all the elements to get an elements name

simtr commented 12 years ago

I just applied and tested the "LIGH fix" commit, it doesn't seem to fix anything

simtr commented 12 years ago

Also, the location of INSL in the menu is very a split issue, its main use was to insulate against HEAT, insulating electronics became a secondary usage and so it stays in the Special menu

simtr commented 12 years ago

Most of these have been merged.

jacob1 commented 12 years ago

Okay, thanks. Is saying the LIGH change doesn't fix anything your way of saying you don't want it to be used like the old way anymore as a good heater? It doesn't look glitchy when it's surrounded by a lot of VOID particles. And I thought you said at one point that you were going to move INSL to electronics, but maybe not.

Also, you made a comment saying '-=321', what does that mean?

simtr commented 12 years ago

I mean it doesn't seem to make Void destroy LIGH, as for my reply, I have no idea what I did.

jacob1 commented 12 years ago

You have to surround a pixel of CLNE(LIGH) with a space and then VOID's, only one won't work. Also, it only stops it when it divides into different lines (I didn't try to stop it everywhere, maybe I should have)

jacob1 commented 12 years ago

Also, I forgot one in the list. Right clicking reload should go back to the save preview so you can comment and do other stuff. And it looks like only 1 of the 5 new settings that are saved in tpt are saved in tpt++ (fullscreen, but that was already being saved). Your commit should have made 2 of them start being saved, but I can't find them in powder.pref and the setting changes don't stay after coming back. I guess version 83 hasn't been released yet...

jacob1 commented 12 years ago

Still some more commits, this time from my very first pull request. I posted about the portal and update bugs in 2 other issues, and I also noticed these:

spark color fix Soap lines - they are in, but should more be like I did it, in all display modes (except I just realized mine also display when nothing at all is on). Maybe combine it with the stickmen graphics value and call it element effects or something smudge tool - this is also in but done separately, and after using it a lot, the deco just disappears. It should use something close to the above code, at least have it not disappear.

I will keep looking for more. Also, are you getting notifications for these posts? I'm not sure if you do since it's closed.

signs can't be placed in the zoom window And one more that I never pushed to the 'official' branch I made because it was messed up and wouldn't merge. This fixes some stickmen bugs, where a new spawn point would be created at PRTO and multiple SPAWN's could be made. I made the 'official' branch for bugfixes like that, but I don't have the time right now to fix and use it.