Minor fixes needed to build on ArchLinux.

simtr / PowderToypp

This repository has been moved to https://github.com/FacialTurd/The-Powder-Toy

https://github.com/FacialTurd/The-Powder-Toy

GNU General Public License v3.0

20 stars 12 forks source link

Minor fixes needed to build on ArchLinux. #195

Closed Huulivoide closed 11 years ago

Huulivoide commented 11 years ago

These fixes are needed in order to build with systems.

that use GCC 4.7+: 1ba412d

that have python3 (Gentoo and Arch at leAST) as 'python' binary and python2 as 'python2': c7ca6ca All major distros (Ubuntu, Fedore, Suse, Gentoo, Arch..) expect Debian have the 'python2' symlink in them. Using 'python2' instead of 'python' maximices the possibilities of having the Sconscript working out-of-the box, without patching.

that are 64bit: ec413dd

General fixes conserning the building process: 0cd04ad & f3aa813

jacob1 commented 11 years ago

1ba412d will definetely break compiling on windows for me, visual studio doesn't have unistd.h. Using #ifndef _MSC_VER will fix that. Maybe you should check that these changes don't break anything else (but that was the only problem I can see)

ntoskrnl11 commented 11 years ago

The last one breaks cross compilation. You should use #idndef WIN or #ifdef LIN instead. LIN is used for all platforms that are not WIN or MACOSX.

Huulivoide commented 11 years ago

It needs to be

#ifndef WIN
#include <uninstd.h>
#endif

then, as OSX also contains this header file and basicly it should be included. Please test if this works. I do not have acces to OSX to test it, nor do I have qorking MVC compiler suite installed on my W7, nor anykind of cross-MinGW in my primary linux system. I'l make another commit later today. But it would be nice to know beforehand if it works and fixes the problem.

ntoskrnl11 commented 11 years ago

The "#ifdef WIN" part hasn't been merged yet.