simularium / binding-sim-edu

Other

0 stars 0 forks source link

Fix/bugs #113

Closed meganrm closed 1 month ago

meganrm commented 1 month ago

Problem

Estimated review size: small

a number of smaller bugs:

the simulation didn't always size correctly to the viewport window
if the content was too long for the window, the play button was off the bottom
the style for the tertiary buttons had gotten overwritten
got new SVGs from Thao
the text content was being centered in both directions

Solution

use the longest axis instead of just the width to determine the window size
put "height: 100%" on the center panel
switch the order of the props on the tertiary button
update the files with the new svg
change the margin: auto to margin-left: auto and margin-right: auto

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

bun dev

Screenshots (optional):

Problem	Before	After
At certain window resolutions you saw the bounding box
I was supposed to center the written content horizontally, but I accidentally did it vertically as well
If you made the window really short vertically, the play button went away