simularium / binding-sim-edu

Other
0 stars 0 forks source link

Feature/resize hook #75

Closed meganrm closed 5 months ago

meganrm commented 5 months ago

Problem

Estimated review size: small All of the panels need to know when the screen has changed sizes

closes #62

Solution

created a hook and a component that gets a new size when the window changes Still to do: resize the 'Record' button

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. bun dev
  2. get to simulation
  3. press play to get the plots to show
  4. they should be sized well
  5. resize the window and the plots should re-render at the correct size again

Screenshots (optional):

Screenshot 2024-04-30 at 2 15 21 PM
meganrm commented 5 months ago

I'm going to read through this, but the diff includes code from feature/style-right-panel-plot and feature/lab-view so I'll probably wait to do a detailed review until those have been merged and this branch points at main? LMK if there is a reason to get this thoroughly checked out before that.

I pulled in the changes. I can't merge this until #67 is merged because this builds on those changes, but you can review these now so whenever that gets reviewed I can merge it all at once