search

simularium / binding-sim-edu

Other
0 stars 0 forks source link

Cleanup and troubleshooting #85

Closed meganrm closed 4 months ago

meganrm commented 4 months ago

Problem

Estimated review size: small

I had found a bug were the viewport was sometimes not updating when the concentration slider was changed. I eventually figured out it was mainly problem with caching on the viewer

Solution

The fix to the bug is in the viewer, but there changes in this branch that I think are an improvement overall

  1. sometimes the controller returned a time of zero, so I'm now storing the time that comes from the playback
  2. I separated out what happens when the user grabs the slider and moves it around (without letting go) verses when they finish and select a new concentration
  3. changed the max concentration for the module to 10, since it doesn't really need the higher values
  4. made sure all the values for an agent are in sync (and not any left over from the previous settings)