search

simularium / simularium-planning

Apache License 2.0
0 stars 0 forks source link

Issues around state tags that exist on every agent having checkboxes #120

Open meganrm opened 3 years ago

meganrm commented 3 years ago

Description

For a model with nested checkboxes, when you uncheck all the boxes, and then check them on one at a time, it's not consistently showing agents that have the visible checkboxes. For the actin model, all the actin agents have ATP, so if you uncheck ATP, regardless of what else you turn on, the agents are hidden.

Expected Behavior

Each check box state turned on should show agents with that tag, regardless of the other tags they have.

Reproduction

Using this actin model, uncheck all actin, then turn on any except ATP, and you wont see see anything turn on. Then turn ATP on, and any other checkbox, and you'll see the agents go on.

Environment

Any additional information about your environment. E.g. OS version, python version, browser etc.

meganrm commented 2 years ago

I looked into this more, and realized the real issue is having tags that exist on every agent. Either way, it's going to result in non intuitive results when clicking checkboxes. I think a better solution is to not include any tags that are present on every agent in the UiDisplayData

meganrm commented 2 years ago

Or, we could include those in the parent name, ie for the actin file, the parent would be Actin (ATP, free) or something.

blairlyons commented 2 years ago

part of simularium/simularium-planning#31