search

simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Initial camera view zoomed far out #330

Closed blairlyons closed 3 months ago

blairlyons commented 11 months ago

Description

The camera starts further zoomed out since recent camera mode changes.

Expected Behavior

The initial camera view should be similar even with the camera mode updates.

Reproduction

  1. Load this trajectory from a collaborator.
  2. Load the same file on staging (which has the camera mode updates v3.6.2)

Environment

Firefox, staging

ShrimpCryptid commented 4 months ago

Had a discussion with Blair about this!

I implemented a fix that applies some smart scaling, but Dan pointed out that it doesn't respect the provided camera data in Simularium files. On looking closer, it seems like the camera data for the example file is provided (using a default setting, Z=120), so doing a check for missing camera data would not solve this case.

Blair says she doesn't want to do any "smart fixes" and it may be best to just leave the viewer as-is; the files will need to be updated on the scientist's end.

@toloudis tagging you here for visibility! Will close this once I get a chance to check in with you.

ShrimpCryptid commented 3 months ago
ShrimpCryptid commented 3 months ago

Closed, idea continued in https://github.com/simularium/simularium-planning/issues/191.