search

simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

change dropbox links #335

Closed meganrm closed 1 year ago

meganrm commented 1 year ago

Problem

Dropbox links to OBJ files started having a CORS error

Solution

I replaced the www.dropbox.com with dl.dropboxusercontent.com based on this post They do note in the post that dl.dropboxusercontent.com is an old style that they still support "for now" so we'll have to keep an eye on it. I did ask in the forum if they plan to address the CORS issue with the new link style, so we'll see what they say.

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. npm start
  2. open test bed viewer
  3. drag and drop this file
  4. should see structures

Screenshots (optional):

Screenshot 2023-10-11 at 10 16 41 AM
github-actions[bot] commented 1 year ago

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.18% 1962/4882
🔴 Branches 43.88% 821/1871
🔴 Functions 37.13% 404/1088
🔴 Lines 40.46% 1880/4646

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold