simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

install @types/babel__traverse@7.18.3 #351

Closed interim17 closed 9 months ago

interim17 commented 9 months ago

Problem

I found that I could not build the viewer from main because our typescript version was out of sync with @types/babel__traverse Found some other folks in github threads facing a similar problem

Installing @types/babel__traverse@7.18.3 fixes it.

Here's the error text I was seeing if you would like to compare to your experience:

node_modules/@types/babel__traverse/index.d.ts:314:10 - error TS1023: An index signature parameter type must be either 'string' or 'number'.

314         [k: `${string}|${string}`]: VisitNode<S, Node>;
             ~

Found 1 error.

ERROR: "generateTypes" exited with 2.
github-actions[bot] commented 9 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 45.86% 2251/4908
๐Ÿ”ด Branches 44.75% 840/1877
๐Ÿ”ด Functions 43.48% 474/1090
๐Ÿ”ด Lines 45.85% 2143/4673

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold

meganrm commented 9 months ago

why is it babel_traverse and not @babel/traverse?

toloudis commented 9 months ago

I'd love to see us just update all dev dependencies wholesale to the latest major.minor versions (except for react, antd and whatever else might incur major code changes). This feels like a bandaid somewhat but it also seems pretty harmless!

toloudis commented 9 months ago

@interim17 can you see if #354 fixed this build issue?

interim17 commented 9 months ago

@toloudis yes it fixes it! appreciate the discussion it's useful for me.

interim17 commented 9 months ago

354 fixed this!