Feature/freeze camera

[meganrm]

Problem

The education module will not need camera controls because it's a 2d simulation

Solution

I added a prop called stationaryViewport that defaults to false.

NOTES/QUESTIONS:

1. I made the assumption here that this setting is unlikely to change for a simulation. It's set when the canvas is mounted and nothing would happen if the prop changed but the canvas isn't remounted. I can add the ability to have it react to the prop change, but it's not needed for the education simulation and so I'm partial to waiting until it's a requirement for something else but open to changing if other people feel differently.
2. any ideas for a clearer prop name are welcome. I could also see the argument for having a movableViewport prop that defaults to true

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Steps to Verify:

1. npm start
2. change stationaryViewport to true in the example viewer
3. camera controls shouldn't work and nothing should happen when you click on an agent.

[github-actions[bot]]

jest coverage report 🧪

Total coverage

Status	Category	Percentage	Covered / Total
🔴	Statements	40.48%	2044/5049
🔴	Branches	43.35%	845/1949
🔴	Functions	36.9%	417/1130
🔴	Lines	40.69%	1957/4809

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :-------------- | :--------- | :------- | :-------- | :------ | | 🔴 | index.ts | 7.76% | 7.37% | 5.78% | 7.73% | | 🔴 | src/viewport | 15.27% | 10.95% | 15.78% | 14.81% | | 🔴 | index.tsx | 15.27% | 10.95% | 15.78% | 14.81% | | 🔴 | src/visGeometry | 21.89% | 22.95% | 27.92% | 21.78% | > Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

[interim17]

LGTM, left some ideas about future work on configuring controls.

I don't mind stationaryViewport but I might prefer freezeCamera,disableCameraMovement, fixedCameraPosition(and flip the boolean) or something like that, since we are preventing camera movement within the viewport. Not a strong preference though, fine with me to leave as is.

[toloudis]

I saw that you don't allow the "follow" behavior. Do you still want to allow mouse clicking to pick an agent?

[toloudis]

I don't mind stationaryViewport but I might prefer freezeCamera,disableCameraMovement, fixedCameraPosition(and flip the boolean) or something like that, since we are preventing camera movement within the viewport. Not a strong preference though, fine with me to leave as is.

or maybe lockedCamera...

[meganrm]

I saw that you don't allow the "follow" behavior. Do you still want to allow mouse clicking to pick an agent?

It doesn't really matter if an agent is "picked" as long as we're not following it. For completeness are you saying I should also make it so click on an agent doesn't save the id?

[toloudis]

I saw that you don't allow the "follow" behavior. Do you still want to allow mouse clicking to pick an agent?

It doesn't really matter if an agent is "picked" as long as we're not following it. For completeness are you saying I should also make it so click on an agent doesn't save the id?

I don't mind either way but it can result in the agent being selected and outlined. Just want to make sure we are intentional. My comment was just about being able to document (in the code in comments near where the prop is defined, or something) to know exactly what is supposed to be locked down when this prop is set.