search

simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Fix/create root #365

Closed interim17 closed 6 months ago

interim17 commented 6 months ago

Test-bed viewer was not actually running React 18 because the render API hadn't been switched over to createRoot, meaning we were in React 17 legacy mode, this makes that change.

Note: codec issues solved in separate PR, this is just the React change now

github-actions[bot] commented 6 months ago

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.48% 2044/5049
🔴 Branches 43.35% 845/1949
🔴 Functions 36.9% 417/1130
🔴 Lines 40.69% 1957/4809

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

toloudis commented 6 months ago

I wonder if it could have been a browser version update that happened coincidentally at the same time

interim17 commented 6 months ago

I wonder if it could have been a browser version update that happened coincidentally at the same time

Couldn't be me nervously updating Chrome...

Issues persist, but I think I'm on to a (partial) fix for the codec.