simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Fix/video config #366

Closed interim17 closed 6 months ago

interim17 commented 6 months ago

The VideoEncoder avc codecs are failing unless we provide them only even numbers for width and height.

In debugging this I explored the codecs a bit and tweaked a few things, aiming for high quality output with reasonable file sizes:

github-actions[bot] commented 6 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 40.46% 2044/5051
๐Ÿ”ด Branches 43.35% 845/1949
๐Ÿ”ด Functions 36.9% 417/1130
๐Ÿ”ด Lines 40.67% 1957/4811

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold

Show files with reduced coverage ๐Ÿ”ป ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :--------------- | :--------- | :------- | :-------- | :------ | | ๐ŸŸก | src/simularium | 60.42% | 58.45% | 49.01% | 61.31% | | ๐Ÿ”ด | FrameRecorder.ts | 28.91% | 33.33% | 25% | 28.75% | > Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold