search

simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

move webpack to example viewer #371

Closed meganrm closed 5 months ago

meganrm commented 5 months ago

Time Estimate or Size

small

Problem

The test bed viewer app is the only thing that needs web pack but we still had it in our main package.json closes #358

Solution

removed all web packfrom main code

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. do a fresh install of node modules
  2. npm run build should work
  3. npm start should open up test bed viewer
github-actions[bot] commented 5 months ago

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.38% 2045/5064
🔴 Branches 43.22% 845/1955
🔴 Functions 36.77% 417/1134
🔴 Lines 40.6% 1958/4822

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold