simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Feature/turn controls back on #378

Closed meganrm closed 4 months ago

meganrm commented 4 months ago

Time Estimate or Size

xsmall

Problem

for the education module: I originally thought I would use a separate instance of the viewer when changing to 3d trajectories, but the setup I have is just switching files so I need to be able to turn the controls on and off

Solution

added a toggle function that gets called when the prop is changed

Type of change

Please delete options that are not relevant.

github-actions[bot] commented 4 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 40.32% 2045/5071
๐Ÿ”ด Branches 43.13% 845/1959
๐Ÿ”ด Functions 36.7% 417/1136
๐Ÿ”ด Lines 40.54% 1958/4829

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold

Show files with reduced coverage ๐Ÿ”ป ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :-------------- | :--------- | :------- | :-------- | :------ | | ๐Ÿ”ด | index.ts | 7.74% | 7.31% | 5.73% | 7.7% | | ๐Ÿ”ด | src/viewport | 14.84% | 10.81% | 15% | 14.38% | | ๐Ÿ”ด | index.tsx | 14.84% | 10.81% | 15% | 14.38% | | ๐Ÿ”ด | src/visGeometry | 21.82% | 22.87% | 27.71% | 21.71% | > Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold