simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

don't give a parent a color of the children have different colors #379

Closed meganrm closed 4 months ago

meganrm commented 4 months ago

Time Estimate or Size

xsmall

Problem

closes https://github.com/simularium/simularium-website/issues/505

Solution

The parent was getting assigned a color of its first child, so the UIData sent to the website gave the parent a color, even though it wasn't displayed it was keeping the children from being open

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. go to https://staging.simularium.allencell.org/viewer?trajUrl=https://aics-simularium-data.s3.us-east-2.amazonaws.com/trajectory/binding-affinity_antibodies.simularium
  2. The Antibody parent is closed
  3. install this version of the viewer in the simularium-website locally
  4. go to http://localhost:9001/viewer?trajUrl=https://aics-simularium-data.s3.us-east-2.amazonaws.com/trajectory/binding-affinity_antibodies.simularium
  5. it's fixed

Screenshots (optional):

without this change, Antibody parent has been assigned the color of it's first child

Screenshot 2024-05-03 at 11 50 11 AM

with these changes: parent doesn't have a color

Screenshot 2024-05-03 at 11 43 59 AM
github-actions[bot] commented 4 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 40.4% 2048/5069
๐Ÿ”ด Branches 43.22% 845/1955
๐Ÿ”ด Functions 36.79% 418/1136
๐Ÿ”ด Lines 40.62% 1961/4827

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold