simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Feature/change to converted file #380

Closed interim17 closed 3 months ago

interim17 commented 4 months ago

website branch fix/conversion-filename-bug points at these changes to receive file that results from autoconversion

Time Estimate or Size

small-ish

Problem

The handling of autoconverted files was built in the viewer with the example viewer in mind, but now that we're integrating with the website repo, we need to make some minor changes to the viewer.

The way autoconverted files are currently handled in the viewer is that the viewer requests a file to be converted and immediately requests frame 0. However, in the website, we want to clear any previous trajectory in between these two steps, allowing users to resume interacting with the previous simulation if they cancel the autoconversion request before octopus has replied with the converted data.

Solution

with @ascibisz

Type of change

github-actions[bot] commented 4 months ago

jest coverage report πŸ§ͺ

Total coverage

Status Category Percentage Covered / Total
πŸ”΄ Statements 40.37% 2048/5073
πŸ”΄ Branches 43.02% 845/1964
πŸ”΄ Functions 36.79% 418/1136
πŸ”΄ Lines 40.59% 1961/4831

Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Show files with reduced coverage πŸ”» ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :----------------- | :--------- | :---------------- | :-------- | :------ | | πŸ”΄ | src/controller | 30.09% | 14.78% | 16.94% | 30.43% | | 🟑 | src/simularium | 60.32% | 57.69% | 49.14% | 61.19% | | πŸ”΄ | RemoteSimulator.ts | 48.85% | 62.5% (-4.16% πŸ”») | 27.27% | 52.1% | > Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold