search

simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Fix/no firstframetime #382

Closed interim17 closed 3 months ago

interim17 commented 4 months ago

Time Estimate or Size

small

Problem

Closes #362

Solution

Recent changes to octopus and this @ascibisz PR from yesterday seem to have mostly resolved these bugs. We don't need to subtract firstFrameTime anymore, when calling goToRemoteSimulationTime and so visData.firstFrameTime isn't being used anywhere. I just removed all reference to it. The front end gets the correct firstFrameTime by reading the timeData when the trajectory lands, we dont need to store it in the viewer.

Prior to realizing Alli had already fixed this I wrote code that I think improves on how we were storing firstFrameTime if we want it later, but for now I think we can just remove it

Start time of 0 was hard coded into the test bed slider. I changed it to act more like the website and get the value from timeData on initial play.

Steps to Verify:

  1. Install viewer in website
  2. Try all the playback controls for the trajectories linked in the issue without hitting play first and see if you get hung up on anything and if first frame time displays correctly.
github-actions[bot] commented 4 months ago

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 40.37% 2045/5065
🔴 Branches 43.01% 843/1960
🔴 Functions 36.79% 418/1136
🔴 Lines 40.59% 1958/4823

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻 ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :------------- | :--------- | :---------------- | :-------- | :------ | | 🟡 | src/simularium | 60.28% | 57.56% | 49.14% | 61.15% | | 🔴 | VisData.ts | 32.68% | 36.53% (-1.2% 🔻) | 41.86% | 33.46% | > Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold