simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

feat: Camera distance is now scaled to >= 90% of the screen real estate #383

Closed ShrimpCryptid closed 3 months ago

ShrimpCryptid commented 3 months ago

Time Estimate or Size

Estimated size: small, 5-10 minutes

Problem

Closes #330, a bug where the camera would be zoomed too far out on reset.

Solution

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. Clone the branch and build.
  2. Change your local clone of the simularium-website repo to use your local, built version of volume-viewer.
  3. Open the following file: https://www.dropbox.com/scl/fi/2srfuliyjnu3sr1tlfgwf/cells_2023-10-04.simularium?rlkey=hg35vs9cwrla19eq2m0al81t4
  4. Switch between orthographic and perspective mode and reset the camera to home.
  5. Go to the main page and open other simulations. They should look the same or be slightly closer to the camera than before.

Screenshots (optional):

Before After
image image
image image
Unchanged: Before After
image image
github-actions[bot] commented 3 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 40.25% 2048/5087
๐Ÿ”ด Branches 42.93% 845/1968
๐Ÿ”ด Functions 36.79% 418/1136
๐Ÿ”ด Lines 40.47% 1961/4845

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold

Show files with reduced coverage ๐Ÿ”ป ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :-------------- | :--------- | :------- | :-------- | :------ | | ๐Ÿ”ด | index.ts | 7.6% | 7.2% | 5.73% | 7.56% | | ๐Ÿ”ด | src/visGeometry | 21.63% | 22.71% | 27.71% | 21.51% | > Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold