simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D
Apache License 2.0
2 stars 0 forks source link

Fix/remove simularium engine specific code #391

Closed ascibisz closed 3 months ago

ascibisz commented 3 months ago

Time Estimate or Size

small

Problem

As we fully transition to octopus, it's time to strip out the simularium-engine specific code that is no longer useful Link to story or ticket

Solution

A website PR will need to be made after this, updating their NetConnectionParams to remove useOctopus

github-actions[bot] commented 3 months ago

jest coverage report ๐Ÿงช

Total coverage

Status Category Percentage Covered / Total
๐Ÿ”ด Statements 41.05% 2039/4966
๐Ÿ”ด Branches 43.3% 838/1935
๐Ÿ”ด Functions 37.15% 418/1125
๐Ÿ”ด Lines 41.28% 1952/4728

Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold

Show files with reduced coverage ๐Ÿ”ป ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :----------------- | :--------- | :----------------- | :-------- | :----------------- | | ๐ŸŸก | src/simularium | 64.36% | 59.76% | 50.63% | 65.32% | | ๐Ÿ”ด | RemoteSimulator.ts | 48.71% | 60.71% (-1.79% ๐Ÿ”ป) | 27.41% | 52.38% (+1.15% ๐Ÿ”ผ) | | ๐ŸŸข | WebsocketClient.ts | 82.66% | 69.44% | 69.69% | 83.56% | > Status of coverage: ๐ŸŸข - ok, ๐ŸŸก - slightly more than threshold, ๐Ÿ”ด - under the threshold