simularium / simularium-viewer

NPM package to view Simularium trajectories in 3D

Apache License 2.0

2 stars 0 forks source link

convert vis-type to visType at parse time #393

Closed interim17 closed 2 months ago

interim17 commented 3 months ago

Time Estimate or Size

small

Problem

There were todo comments in the code about converting the ["vis-type]" key in AgentData to visType

Solution

Added checks in parsing functions to output visType properties when incoming data has vis-type properties. Trajectories are running and tests are passing.

Bug fix (non-breaking change which fixes an issue)

github-actions[bot] commented 3 months ago

jest coverage report 🧪

Total coverage

Status	Category	Percentage	Covered / Total
🔴	Statements	40.97%	2042/4983
🔴	Branches	43.21%	838/1939
🔴	Functions	36.99%	418/1130
🔴	Lines	41.2%	1955/4745

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

interim17 commented 2 months ago

Thanks for making this change. Looks like all uses of "vis-type" can just disappear forever now ...?

Yes, done!