Closed interim17 closed 2 weeks ago
Status | Category | Percentage | Covered / Total |
---|---|---|---|
π΄ | Statements | 40.95% | 2043/4989 |
π΄ | Branches | 43.21% | 838/1939 |
π΄ | Functions | 36.92% | 418/1132 |
π΄ | Lines | 41.17% | 1956/4751 |
Status of coverage: π’ - ok, π‘ - slightly more than threshold, π΄ - under the threshold
looks good, I would pull out the AgentData fix into it's own PR and make sure the exports are consistent with how we're exporting all the other types from the system
For context for other reviewers, this is done, the fix has been merged into both main and this branch.
Time Estimate or Size
medium
related website branchs:
fix/update-ssi
-> a patch to bring website into alignment with this changesetfeature/color-session
-> the end goal for the feature in developmentAdvances #510 and #511
Problem
On the front end we need to be storing and applying sets of color changes (browser sessions, or re-applying default). Current code assumes one-color-change-at-a-time.
Solution
UIDisplayData
is a good existing data structure that conveys a snapshot of agent tree and its colors.In
SelectionStateInfo
colorChanges
have been replaced byappliedColors
of typeUIDisplayData
This is more consistent with the other parts of the selection object which serves as a snapshot of the selection state, rather than as a pass-through for a series of changes.
Keeping this change set small. Possible further changes would keep the
SelectionInterface
entries
object in sync with "rendered state"... Might be useful for writing changes out to new files, not needed right now for MVP.Type of change