Closed interim17 closed 11 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 75.3% | 558/741 |
π‘ | Branches | 70.64% | 77/109 |
π΄ | Functions | 42.61% | 75/176 |
π‘ | Lines | 73.89% | 501/678 |
90 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 10849ca69610bfeb84b2122d8498a602466146a2
seems like the things this was waiting for are merged?
seems like the things this was waiting for are merged?
Some of it is in the auto-conversion branch, but I can move this forward anyway.
The lingering question for me was about engine version. Website and Viewer versions are constants grabbed from npm packages. But this ticket doesn't seem like its worth going into simulariumengine to make changes to export current version. Maybe that is accessible somewhere and I missed it?
I could hardcode the current SimEngine version for this MVP, or just print the modal with just Website and Viewer versions for now?
some unresolved discussion from May: https://github.com/simularium/simularium-website/issues/304#issuecomment-1571034682 Absent your guidance I'll just move this forward without engine version
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 74.94% | 589/786 |
π‘ | Branches | 70.18% | 80/114 |
π΄ | Functions | 42.16% | 78/185 |
π‘ | Lines | 73.5% | 527/717 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 836510a92366a61ef1dbc455f17838f92a638322
ok, I did a force update. this problem arises because we squash merge our main branch so old branches don't "know" that the commits are in the main branch. Double check that this has all your changes
Thanks for the fix, seems to have all my changes. I noticed an odd css quirk I didn't see before.
After clicking the menu option it would briefly remain highlighted when reopening the help menu. I've pushed a small css rule that fixes this.
.menu :global(.ant-dropdown-menu-item-active){
background-color: transparent !important;
}
Would love to avoid these !important
tags but they are often the easiest way to circumvent antd styling, especially on elements where antd applies a range of classes and pseudo classes after clicks and other interactions.
Problem
Mostly closes #304 Leaving out Engine version for now, will revisit in Octopus era.
Change summary:
Opens a modal to display version info when help menu item is selected.
Steps to Verify:
Find 'Version Info' in help menu and open the modal.