search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
7 stars 3 forks source link

fix menus offsets #440

Closed meganrm closed 1 year ago

meganrm commented 1 year ago

Problem

This closes #438 and it might fix #435

Solution

There was some styling that was overriding the default antd submenu. I fixed it, and also updated the help dropdown which was using old components.

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. npm start
  2. drop downs work

Screenshots (optional):

Screenshot 2023-10-09 at 3 34 13 PM Screenshot 2023-10-09 at 3 34 18 PM
github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements 74.94% 589/786
🟡 Branches 70.18% 80/114
🔴 Functions 42.16% 78/185
🟡 Lines 73.5% 527/717

Test suite run success

99 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 308425d9af66301182bdc1e256b1c1eb472a3bf6

interim17 commented 1 year ago

LGTM :)

Haven't tried on an actual phone, but Help menu works when simulating mobile device with dev tools.