Closed interim17 closed 9 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 74.9% (-0.03% π») |
588/785 |
π‘ | Branches | 70.18% | 80/114 |
π΄ | Functions | 42.16% | 78/185 |
π‘ | Lines | 73.46% (-0.04% π») |
526/716 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from e8ba9a01e87b93839ae1b5eb95e348cc2218efe8
can you add before and after screen shots?
@meganrm Added some screenshots of before and after for disabled and hover states. Let me know if you'd like to see anything else.
Problem
@lynwilhelm pointed out some styling mistakes on the
Share
andDownload
buttons, and added a couple tweaks not in the original designs. Designs here and hereThis PR should fix those problems and I added a couple readability changes. I went over the visual changes with @lynwilhelm in a huddle so feel confident this branch reflects design intentions.
Styling changes:
Note about selectors:
.container :global(.ant-tooltip-open.ant-btn)
The hover state and tooltip open behavior were not in sync, so this rule is used of the:hover
pseudo-class.@lynwilhelm also noticed a bug that I could not reproduce where a tooltip would open automatically when a trajectory is loaded, if the user had hovered over the share button BEFORE loading the trajectory. I'm crossing my fingers that some of these changes will resolve that issue, but please let me know if you can reproduce it on this branch.
Steps to Verify:
Screenshots:
Before, disabled:
Before, hover:
After, disabled:
After, hover: