search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Fix/cancel file icon #456

Closed interim17 closed 6 months ago

interim17 commented 8 months ago

Problem

A previous PR of mine left the styling incorrect on the icon that removes/cancels the uploaded file: It had the default trash icon and also only appeared during hover.

There are couple little tweaks to button and select styling here, as well as some css organization.

Antd button was hard to target and change icon of, so I put display: none on that class and implemented a simple function on a div to replace it.

Old/incorrect: Screenshot 2023-12-14 at 2 48 04 PM New: Screenshot 2023-12-14 at 3 27 08 PM Design: Screenshot 2023-12-14 at 2 49 11 PM

Steps to Verify:

Should look like the design, and when you click the red icon, any uploaded file should be removed.

interim17 commented 7 months ago

Adding a comment so Github tracks it, will re-review once the styling for the cancel icon is moved!

@ShrimpCryptid what do you think of this pattern? FWIW, it matches a couple of pairs of icons in the same file.