Closed interim17 closed 6 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 73.24% | 602/822 |
π‘ | Branches | 68.38% | 80/117 |
π΄ | Functions | 40.31% | 79/196 |
π‘ | Lines | 71.7% | 537/749 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 2e20eecedae7f5d671dcfb7f1628cbe8aa7a3342
Problem - React 18
Bumping react to be in sync with viewer.
A couple other dependencies seemed to need come along,
react-dom, @types/react-dom, @types/react, react-waypoint
. Alsochildren
is no longer a default prop on some components so I added it to a couple interfaces.The only change that seems more significant is: In React 18 the legacy render method is replaced with
createRoot
.Using the legacy API will cause the app to run as if its in React 17. We should use the new API so we are running the version we think we're running. The container for root could possible be null and these docs show this non-null assertion:
But that seems not safe and the linter doesn't like it so I used a ternary check, thoughts?