simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Autoconversion Fixes #462

Closed ascibisz closed 5 months ago

ascibisz commented 7 months ago

Problem

This is a somewhat large PR that solves three needs: 1) Need to send the file to Octopus to get it converted. 2) Receive the converted file from Octopus. 3) Front end errors arising from switching backends.

@interim17 did most of the work for this PR, @ascibisz helped with some debugging and happened to be the one to open the PR because she had the time to

Solution

Convert the file

Redux action/logic being triggered to send the file to Octopus. As always with redux there is much boiler plate, the action is in convertFileLogic which does the sending.

Receive the converted file

To receive the file we need a configured viewer at the ready, so Joe refactored the routes so that the conversion form is just a component that is just visible in front of the viewer when the user opens it. This made some of the communication with Octopus simpler. We're always at /viewer ready to receive a file, and we handle navigation in and out of the conversion form with conversionState.

Errors

Alli then did some miscellaneous debugging, as well as switching the autoconversion feature branch to use octopus for everything, not just the autoconversion point. The infrastructure team is actively working on the octopus deployment, so rather than continuing to have a weird state of partially using octopus and partially using simularium-engine, we think it makes sense to have this feature branch ready to fully embrace octopus.