simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Load from url input is right justified #464

Closed meganrm closed 6 months ago

meganrm commented 6 months ago

Description

The "load from url" text input is formatted weirdly: it's right justified which is confusing.

Screenshot 2024-02-14 at 5 57 12 PM

Expected Behavior

I think this is the design. Although it might not be the most recent: @lynwilhelm can you make sure the right one is linked here?

Reproduction

A minimal example that exhibits the behavior.

Environment

Looks like this on chrome, safari and edge

meganrm commented 6 months ago

I think what happened here is the "share trajectory" input is left justified to show the time param and that style got applied to the other modal too

meganrm commented 6 months ago

it also look like there is an extra border

lynwilhelm commented 6 months ago

Yes, that is the most current design. I am not partial to the hint text being a URL... or "Start typing..." but yes, it should be left justified. After the user input a URL however, I think it could be useful for the user to be able to see the end of that string (filename). I don't think that would require a right justify though.

meganrm commented 6 months ago

Yes, that is the most current design. I am not partial to the hint text being a URL... or "Start typing..." but yes, it should be left justified. After the user input a URL however, I think it could be useful for the user to be able to see the end of that string (filename). I don't think that would require a right justify though.

Thanks! what should the hint text be?

This is what it looks like when you enter a url, they can be very long. we could pull out the file name and put it under the input box. For now I'm going to make it look like the current design (plus any change in the hint text you decide on). Let me know if you think we should make any other changes

Screenshot 2024-02-15 at 9 37 14 AM