simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

fix the html loader result #475

Closed meganrm closed 6 months ago

meganrm commented 6 months ago

Time estimate or Size

small

Problem

the html-loader was exporting a module instead of just the png for the og tag image

Solution

I added the esModules: false While I was investigating this, I realized we already had HtmlWebpackPlugin which you can use to set metatags that don't need any processing done to them, so I also moved all the tags without paths into there.

Verify

I deployed it on gh-pages and you can see the preview: https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fsimularium.github.io%2Fsimularium-website

Type of change

Please delete options that are not relevant.

I was able to test this by momentarily overwriting a nightly build and the image loaded.

github-actions[bot] commented 6 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 73.27% 603/823
🟑 Branches 68.38% 80/117
πŸ”΄ Functions 40.31% 79/196
🟑 Lines 71.73% 538/750

Test suite run success

99 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from 59b258dd96cac04788ce1902e0a08bbd14390df6