Closed meganrm closed 6 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 73.27% | 603/823 |
π‘ | Branches | 68.38% | 80/117 |
π΄ | Functions | 40.31% | 79/196 |
π‘ | Lines | 71.73% | 538/750 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 59b258dd96cac04788ce1902e0a08bbd14390df6
Time estimate or Size
small
Problem
the
html-loader
was exporting a module instead of just the png for the og tag imageSolution
I added the
esModules: false
While I was investigating this, I realized we already hadHtmlWebpackPlugin
which you can use to set metatags that don't need any processing done to them, so I also moved all the tags without paths into there.Verify
I deployed it on gh-pages and you can see the preview: https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fsimularium.github.io%2Fsimularium-website
Type of change
Please delete options that are not relevant.
I was able to test this by momentarily overwriting a nightly build and the image loaded.