simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Fix/icomoon #476

Closed interim17 closed 5 months ago

interim17 commented 6 months ago

Time to review:

Small < 10 minutes

Problem:

Icomoon font glyphs had not been updated in a long time and they were written into the code base in hard to understand ways. New icons had been added in other ways, with conflicting design approaches.

Solution:

Create new set of glyphs, define each glyph as a css variable, apply those variables via global style selectors. I added some explanatory comments about how to use this styling pattern because I found it confusing at first, which led to me adding icons in suboptimal ways. Updating the font was easy! I just didn't realize...

Part of preliminary changes/maintenance to fixing all styles on the playback and camera control buttons.

Other changes:

Moved global style imports to src/style.css why were they in the SideBar component? Removed some unused style rules, cleaned up an import or two

To review:

Screenshot 2024-03-08 at 9 52 06 AM

Screenshot 2024-03-08 at 9 51 59 AM

github-actions[bot] commented 6 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 73.27% 603/823
🟑 Branches 68.38% 80/117
πŸ”΄ Functions 40.31% 79/196
🟑 Lines 71.73% 538/750

Test suite run success

99 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from 7ca5f105f3bb3d2026f597e137a0f503150b65df