Closed interim17 closed 5 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 73.27% | 603/823 |
π‘ | Branches | 68.38% | 80/117 |
π΄ | Functions | 40.31% | 79/196 |
π‘ | Lines | 71.73% | 538/750 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 7ca5f105f3bb3d2026f597e137a0f503150b65df
Time to review:
Small < 10 minutes
Problem:
Icomoon font glyphs had not been updated in a long time and they were written into the code base in hard to understand ways. New icons had been added in other ways, with conflicting design approaches.
Solution:
Create new set of glyphs, define each glyph as a css variable, apply those variables via global style selectors. I added some explanatory comments about how to use this styling pattern because I found it confusing at first, which led to me adding icons in suboptimal ways. Updating the font was easy! I just didn't realize...
Part of preliminary changes/maintenance to fixing all styles on the playback and camera control buttons.
Other changes:
Moved global style imports to
src/style.css
why were they in theSideBar
component? Removed some unused style rules, cleaned up an import or twoTo review: