Closed interim17 closed 5 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 73.27% | 603/823 |
π‘ | Branches | 68.38% | 80/117 |
π΄ | Functions | 40.31% | 79/196 |
π‘ | Lines | 71.73% | 538/750 |
99 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 2d54a9be5d5b7141c72f007f057e787c5dfc99fd
Time to review:
Medium Design review with UX complete.
Problem
Viewport buttons (camera and playback controls) do not match current style guidance. The code for these buttons and their stylesheets is not DRY.
Solution
Create
ViewportButton
component. EachViewportButton
wraps a button in a tooltip and takes a short list of custom props that get it styled correctly. Implementing components (playback controls, camera controls, forthcoming record movies component) are concise and readable.Relevant re-organizing and re-naming is ongoing in
colors.css
. It's a pain, but if any reviewers would like to use it I have a python script that scans the repo for unused css vars and css properties that use variables that aren't actually defined (there were several!) that is making this somewhat less painful T_TSteps to Verify:
Screenshots (optional):
Old:
New: