simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Fix/update custom modal #482

Closed interim17 closed 5 months ago

interim17 commented 5 months ago

Time estimate or Size

Review time: small

Problem

Ongoing style fixes for modals needed, CustomModal wrapper had potential to do more lifting. Color variable renaming and organizing continues. Changes to LandingPage and VisualGlossary are just color renames.

Solution

Handle more styling and layout at wrapper level. In future, simple modals will need minimal styling, see changes to ViewerModal stylesheet.

New CustomModal props:

Divider: boolean flag instead of rendering <Divider /> in individual modals.

Title: implements custom SVG from UX and situates it in header instead of body so it stays centered when header size changes.

Footer: implements divider, and containers for buttons and footer overall to standardize spacing/layout.

FileUploadModal changes requested by UX:

tab text size smaller, tab text bold only when selected

General modal tweaks and fixes requested by UX or indicated in SSOT figma:

modal headers: font now 16px, 400 weight, header height 46px input fields: border color, border radius corrected gaps/spacing in ShareTrajectoryModal updated

Steps to Verify:

  1. Open each modal and compare to figma SSOT

Screenshots:

Screenshot 2024-03-25 at 2 01 30 PM Screenshot 2024-03-25 at 2 01 21 PM

github-actions[bot] commented 5 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements 73.27% 603/823
🟡 Branches 68.38% 80/117
🔴 Functions 40.31% 79/196
🟡 Lines 71.73% 538/750

Test suite run success

99 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 5457a6abccacee2a96fad957c1d39d8b956d1835