simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Feature/record movie UI #483

Closed interim17 closed 4 months ago

interim17 commented 5 months ago

Time estimate or Size

Review time: medium

Problem

Closes #327

Solution

RecordMovieComponent manages the modal and button, retrieves and formats the various display icons and text, defines the downloading function, and calls the viewer handlers it receives.

Modal is trim, no logic.

Minimized storing state in ViewerPanel: only holding the url for the blob.

Steps to Verify:

On supported browsers:

  1. Load a trajectory, click record, confirm that recording indicator shows up next to button.
  2. During playback the record button should pulse red unless hovering, when it should show a red square.
  3. Click stop recording, and then confirm download via the modal.
  4. Check that the downloaded movie is playable.

On unsupported browsers (Firefox, and apparently sometimes Safari):

  1. Confirm that the button has disabled styling and does nothing when clicked.

Screenshots (optional):

Screenshot 2024-03-26 at 10 41 52 AM Screenshot 2024-03-26 at 10 41 46 AM Screenshot 2024-03-26 at 10 41 40 AM Screenshot 2024-03-26 at 10 41 34 AM

github-actions[bot] commented 5 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
73.43% (+0.16% πŸ”Ό)
608/828
🟑 Branches
69.92% (+1.54% πŸ”Ό)
86/123
πŸ”΄ Functions
40.61% (+0.3% πŸ”Ό)
80/197
🟑 Lines
71.92% (+0.19% πŸ”Ό)
543/755

Test suite run success

102 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from e93b7a95ccd7b69a482930de494b23982714f500