autoconversion: Fix/conversion filename bug

[interim17]

Time estimate or Size

Medium

This should be working with current viewer patch.

Problem

Converted trajectories were not downloadable, had no titles in the header, and were buggy when loaded after other trajectories.

Solution

The biggest part of this change is a new flow to receive converted files, first handleIncomingConvertedFile in the viewer panel and then receiveConvertedFileLogic in redux.

handleIncomingConvertedFile puts the name and title into state for use in the header, download menu, etc.

The receiveConvertedFileLogic calls controller.changeFile with the right arguments to keep the websocket connection we established during conversion, switching connections was causing bugs.

Some of this was fixed by recent viewer PR, and this change set brings the website into alignment with viewer in how it calls controller methods like convertTrajectory and changeFile.

Miscellaneous changes:

• getIsNetworkedFile selector was checking if files are in TRAJECTORIES constant, but converted files won't always be there in auto-conversion era, removed check

• in octopus era all downloads will point at new HTTP endpoint instead of s3, updated constant and added todo for launch, and adjusted download string to match in getHref

• Bug fix (non-breaking change which fixes an issue)

To review:

• convert a smoldyn file
• when it arrives, check for title in status bar
• download it with download button
• load the downloaded trajectory
• load a different trajectory and try the flow again

[github-actions[bot]]

Coverage report

St.:grey_question:	Category	Percentage	Covered / Total
🟡	Statements	66.6% (-2.17% 🔻)	640/961
🟡	Branches	65.73% (-0.93% 🔻)	94/143
🔴	Functions	35.39% (-1.63% 🔻)	86/243
🟡	Lines	65% (-2.38% 🔻)	572/880

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------- | :--------- | :------- | :-------- | :----- | | 🟢 | constants/index.ts | 100% | 100% | 100% | 100% | | 🟢 |

`...` / conversion-data-types.ts

| 100% | 100% | 100% | 100% | | 🟢 | util/index.ts | 100% | 100% | 100% | 100% | | 🟢 |

`...` / userUrlHandling.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / interfaces.ts

| 100% | 100% | 100% | 100% | | 🟢 | state/index.ts | 100% | 100% | 66.67% | 100% | | 🔴 |

`...` / reducer.ts

| 21.43% | 100% | 0% | 21.43% | | 🟢 | state/util.ts | 100% | 77.78% | 100% | 100% | | 🟢 |

`...` / constants.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / types.ts

| 90.91% | 100% | 66.67% | 88.89% | | 🔴 |

`...` / reducer.ts

| 21.74% | 100% | 0% | 21.74% | | 🟢 |

`...` / constants.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / reducer.ts

| 27.27% | 0% | 0% | 27.27% | | 🟢 |

`...` / constants.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / types.ts

| 100% | 100% | 100% | 100% | | 🟡 |

`...` / reducer.ts

| 71.43% | 100% | 0% | 71.43% | | 🟢 |

`...` / constants.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / actions.ts

| 51.43% | 100% | 0% | 51.43% | | 🔴 |

`...` / logics.ts

| 15.91% | 0% | 0% | 16.28% | | 🔴 |

`...` / actions.ts

| 52.63% | 100% | 0% | 52.63% | | 🟡 |

`...` / actions.ts

| 66.67% | 100% | 0% | 66.67% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / basic.ts

| 66.67% | 100% | 0% | 50% | | 🔴 |

`...` / actions.ts

| 53.33% | 100% | 0% | 53.33% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / basic.ts

| 84.85% | 100% | 54.55% | 83.33% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / logics.ts

| 27.27% | 0% | 0% | 27.27% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / basic.ts

| 88.89% | 100% | 66.67% | 88.89% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / logics.ts

| 45.45% | 0% | 0% | 45.45% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / basic.ts

| 66.67% | 100% | 0% | 85.71% | | 🟢 |

`...` / index.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / logics.ts

| 100% | 100% | 100% | 100% | | 🔴 |

`...` / configure-store.ts

| 56.25% | 0% | 0% | 56.25% | | 🟢 |

`...` / selectors.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / selectors.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / selectors.ts

| 100% | 100% | 100% | 100% | | 🟢 |

`...` / constants.ts

| 100% | 100% | 100% | 100% |

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 6be7a6f68e85bb68c39d3ca8b526e54b33a4d58d

[meganrm]

can you convert this to a draft until the tests have been fixed? (sorry! I accidentally hit the close button instead of the comment button, didn't mean to do that)