search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

rename some functions and test for clarity #496

Closed meganrm closed 3 months ago

meganrm commented 3 months ago

Time estimate or Size

small

Problem

The tests and names of the functions controlling the checkboxes haven't been looked at in a while, and in re-reading the code there were things that were difficult for me to remember how they were working

Solution

re-wrote the tests for clarity. I also noticed with were still adding and empty string for the unmodified state even though I had moved that code to the viewer. It wasn't caught/causing any bugs because the viewer doesn't pay attention to tags if they don't exist in the data.

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. the tests pass
  2. Here is an example with an unmodified state under Arp3 to see that it's still working to turn that on and off. NOTE: it will give you some geo errors, ignore those.
github-actions[bot] commented 3 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
73.14% (-0.13% 🔻)
 599/819
🟡 Branches
67.83% (-0.55% 🔻)
 78/115
🔴 Functions 40.31% 79/196
🟡 Lines
71.58% (-0.15% 🔻)
 534/746

Test suite run success

100 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 67bde84507b686231ab3b878ee08dd3c2fafb5c6