Closed interim17 closed 2 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 68.58% (+0.7% πΌ) |
657/958 |
π‘ | Branches | 65.22% (+1.04% πΌ) |
90/138 |
π΄ | Functions | 36.21% (+0.84% πΌ) |
84/232 |
π‘ | Lines | 67.16% (+0.77% πΌ) |
589/877 |
104 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from 82fed74f17cb075c1c453098079f8f50b0df7e2a
Time estimate or Size
medium
Problem
Closes #489
Solution
ButtonClass
Rather than passing in a string like "primary-button" that will be handled by something like
ButtonClass.Primary
.Bringing
NavButton
into this new system meant tweaking the css selectors to say "primary-button" instead of just "primary" but styling is not actually changed.IconGlyphs
While I was at it I made the enum
IconGlyphs
so that using icomoon glyphs doesnt require manually applying several strings in a class name, seemed like a related enough change for this PR.Steps to Verify: