simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Feature/button constant #501

Closed interim17 closed 2 months ago

interim17 commented 3 months ago

Time estimate or Size

medium

Problem

Closes #489

Solution

ButtonClass

Rather than passing in a string like "primary-button" that will be handled by something like ButtonClass.Primary.

Bringing NavButton into this new system meant tweaking the css selectors to say "primary-button" instead of just "primary" but styling is not actually changed.

IconGlyphs

While I was at it I made the enum IconGlyphs so that using icomoon glyphs doesnt require manually applying several strings in a class name, seemed like a related enough change for this PR.

Steps to Verify:

  1. Everything should look and act the same as before.
github-actions[bot] commented 3 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
68.58% (+0.7% πŸ”Ό)
657/958
🟑 Branches
65.22% (+1.04% πŸ”Ό)
90/138
πŸ”΄ Functions
36.21% (+0.84% πŸ”Ό)
84/232
🟑 Lines
67.16% (+0.77% πŸ”Ό)
589/877
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------- | :--------- | :------- | :-------- | :---- | | 🟒 |
`...` / interfaces.ts
| 100% | 100% | 100% | 100% |

Test suite run success

104 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from 82fed74f17cb075c1c453098079f8f50b0df7e2a