github-actions[bot]
commented
3 months ago Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 67.88% (-5.42% 🔻) |
636/937 |
| 🟡 | Branches | 64.18% (-5.24% 🔻) |
86/134 |
| 🔴 | Functions | 35.37% (-5.24% 🔻) |
81/229 |
| 🟡 | Lines | 66.39% (-5.38% 🔻) |
569/857 |
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines |
| :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------------------ | :--------- | :------- | :-------- | :---- |
| 🟢 | `...` / conversion-data-types.ts
| 100% | 100% | 100% | 100% |
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines |
| :----------------------------------------------------------------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------- | :-------------------------------------------------------------- | :------- | :-------------------------------------------------------------- | :-------------------------------------------------------------- |
| 🔴 | `...` / reducer.ts
| 21.74% (-11.59% 🔻)
| 100% | 0% | 21.74% (-11.59% 🔻)
|
| 🔴 | `...` / actions.ts
| 51.52% (-0.66% 🔻)
| 100% | 0% | 51.52% (-0.66% 🔻)
|
| 🔴 | `...` / logics.ts
| 16.34% (-5.04% 🔻)
| 0% | 0% | 16.75% (-4.62% 🔻)
|
| 🟢 | `...` / basic.ts
| 84.85% (-4.04% 🔻)
| 100% | 54.55% (-12.12% 🔻)
| 83.33% (-9.52% 🔻)
|
Test suite run success
103 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from a52e6c64ac09f88447c64415fd87704901eaa390
Time estimate or Size
Large
Problem
Closes #414
Solution
Lots of development has gone into this branch for over a year!
Where we stand: this branch
346points at the new octopus cluster and has UI and the required functionality to pass Smoldyn files to the server, and received a converted file back.All this code has been through review, but some of it is getting old! And this is just the beginning: there is more to the UI, more conversion types to add, and of course adjustments to make during the move to octopus. There is also one known bug/issue referenced in this PR.
For what it's worth: I think developing this branch in parallel for this long is now creating more headaches than benefits. It would be really great to get this code into
main, onto staging, and then address any bugs, issues, and next steps in that context.with @meganrm @ascibisz @frasercl basically everyone has contributed to this directly or through lots of review.
Type of change