simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Plots not displaying when loading json trajectory data #513

Closed rugeli closed 4 weeks ago

rugeli commented 2 months ago

Description

A clear description of the bug

I was trying to add plot data into trajectory data for cellPACK, and I found out that currently the simularium website loads plots as expected when the data is binary, but fails to display when using json data

Expected Behavior

What did you expect to happen instead? Plots should display correctly regardless of whether the trajectory data is in binary or json format

Reproduction

A minimal example that exhibits the behavior.

Issue encountered - the plots didn't appear when loading json trajectory data with correctly formatted plot data:

Screenshot 2024-05-02 at 3 42 04 PM

Megan and I have tried a quick fix in logics.ts of this repo by adjusting the data reference, but this change would break plot reading from binary data.

Temporary changes made:

Screenshot 2024-04-05 at 1 46 01 PM

Plots loaded successfully for a json file after the change:

Screenshot 2024-04-03 at 2 27 14 PM

However, with the temporary change, loading plots from a binary trajectory failed:

Screenshot 2024-05-02 at 3 39 49 PM