Closed interim17 closed 2 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 68.78% (+0.2% πΌ) |
663/964 |
π‘ | Branches | 65.71% (+0.5% πΌ) |
92/140 |
π΄ | Functions | 36.48% (+0.27% πΌ) |
85/233 |
π‘ | Lines | 67.38% (+0.22% πΌ) |
595/883 |
104 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from c678abcaee87f7ce89a3ad6090aa95bcb5e2f836
Time estimate or Size
small
Problem
Closes #516
Solution
Add a check for file size in
handleFileSelection
This also would have been the fourth conditional render at the top of the JSX, which was looking messy to my eye,.
I made an enum for error types, and consolidated all the modal open/closed states into a single typed value
conversionError
and a single function can now close all the modals, I think it's a lot cleaner this way.