github-actions[bot]
commented
4 months ago Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 66.29% (-0.31% 🔻) |
643/970 |
| 🟡 | Branches | 65.73% | 94/143 |
| 🔴 | Functions | 35.1% (-0.29% 🔻) |
86/245 |
| 🟡 | Lines | 64.68% (-0.32% 🔻) |
575/889 |
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines |
| :----------------------------------------------------------------------------------------------------------------------------------------------------: | :---------------------------------------------------------------- | :------------------------------------------------------------- | :------- | :-------- | :------------------------------------------------------------- |
| 🔴 | `...` / actions.ts
| 51.35% (-0.08% 🔻)
| 100% | 0% | 51.35% (-0.08% 🔻)
|
Test suite run success
104 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 3a308d600dea88d7a1c6fcb2434c23110fd68d8f
Time estimate or Size
small
Problem
Now that we have cancel autoconversion functionality in Octopus, and a cancel autoconversion message that the viewer can send to trigger that, the website should trigger this when a user selects to cancel a conversion request that's processing
Related to this ticket
Solution
Added call to
SimulariumController.cancelConversion()when user has cancelled their conversion request.Did this using redux (for my very first time) since we will likely need to add more functionality to cancelConversionLogic in the future to properly restore the previous state of the viewer when a user has cancelled a conversion request.