search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Fix/plot data update #522

Closed meganrm closed 4 months ago

meganrm commented 4 months ago

Time estimate or Size

xsmall

Problem

the typing of the return of plot data was inconsistent and incorrect. has been addressed in this PR but that is a breaking change that needs to be handled here

Solution

update the plot data unpacking. needs to wait until we release a new version of the viewer

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. install a local version of the viewer from this branch
  2. file to load
  3. the plot should show
  4. you can also load the two test files I just added to verify that they are both loading correctly (the JSON doesn't load plots on the main site now)
github-actions[bot] commented 4 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
68.63% (-0.07% 🔻)
 663/966
🟡 Branches 65.71% 92/140
🔴 Functions 36.48% 85/233
🟡 Lines
67.23% (-0.08% 🔻)
 595/885
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------ | :------------------------------------------------------------- | :------- | :-------- | :------------------------------------------------------------- | | 🔴 |
`...` / logics.ts
|
16.18% (-0.08% 🔻)
| 0% | 0% |
16.58% (-0.08% 🔻)
|

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from f2a26d7965d06ae2d91eb20d17e8fb674bd2647d