simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Bug Fix: Plots not showing up for example trajectories #524

Closed ascibisz closed 1 month ago

ascibisz commented 1 month ago

Time estimate or Size

xsmall

Problem

While I was looking for potential bugs in simularium after octopus launched, I realized that no plots were showing up. I looked at the console, and realized we were getting 404 errors because we were requesting the plot json objects from the wrong spot.

Solution

I re-added DATA_BUCKET_URL, which had been removed previously because in a different use case, this URL was no longer needed. However, we still need this for getting the plots.

Type of change

Side question

Why are our plots saved here? Can't they just be part of the .simularium file?

Before (with bug)

Screen Shot 2024-05-28 at 3 59 12 PM

After

Screen Shot 2024-05-28 at 3 58 09 PM
github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
66.32% (+0.03% πŸ”Ό)
644/971
🟑 Branches 65.73% 94/143
πŸ”΄ Functions 35.1% 86/245
🟑 Lines
64.72% (+0.04% πŸ”Ό)
576/890

Test suite run success

104 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from e540e3b317f720cc2890b61cc3b0d3f65a3291d5