Closed ascibisz closed 1 month ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 66.32% (+0.03% πΌ) |
644/971 |
π‘ | Branches | 65.73% | 94/143 |
π΄ | Functions | 35.1% | 86/245 |
π‘ | Lines | 64.72% (+0.04% πΌ) |
576/890 |
104 tests passing in 7 suites.
Report generated by π§ͺjest coverage report action from e540e3b317f720cc2890b61cc3b0d3f65a3291d5
Time estimate or Size
xsmall
Problem
While I was looking for potential bugs in simularium after octopus launched, I realized that no plots were showing up. I looked at the console, and realized we were getting 404 errors because we were requesting the plot json objects from the wrong spot.
Solution
I re-added
DATA_BUCKET_URL
, which had been removed previously because in a different use case, this URL was no longer needed. However, we still need this for getting the plots.Type of change
Side question
Why are our plots saved here? Can't they just be part of the .simularium file?
Before (with bug)
After