simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

No cookies popup in embeds #537

Closed blairlyons closed 1 day ago

blairlyons commented 2 weeks ago

Use Case

As a user embedding the viewer in another webpage, I don't want the cookies popup appearing in every instance of the viewer on my website every time it loads.

Acceptance Criteria

When a link starts with https://simularium.allencell.org/embed?... the cookies popup is not triggered (because cookies are not saved).

blairlyons commented 2 weeks ago

@thao-do this is the page where I'm testing embeds, and here's the iframe code: <iframe src="https://simularium.allencell.org/embed?trajUrl=https://readdy-working-bucket.s3.us-west-2.amazonaws.com/outputs/actin_compression_cytosim_readdy.simularium&t=199" frameborder="0" allowfullscreen></iframe>

thao-do commented 2 weeks ago

I have altered the cookie banner trigger condition - it's no longer shown when I open the github page. @blairlyons can you double check?

thao-do commented 2 weeks ago

You might want to make a separate ticket for the small screen warning dialog by the way

blairlyons commented 1 day ago

It works! Thanks!!