search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

Fix/small screen warning #539

Closed meganrm closed 3 months ago

meganrm commented 3 months ago

Time estimate or Size

How long do you expect it to take a reviewer to review this PR? xsmall

Problem

closes #536

Solution

check for the embed pathname I also fixed an warning in the console that was caused by not having done called in a logic

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. npm start
  2. make your window small
  3. go to http://localhost:9001/embed?trajFileName=springsalad_condensate_formation_Above_Ksp.simularium
  4. you shouldn't see a warning
  5. go to http://localhost:9001/viewer?trajFileName=springsalad_condensate_formation_Above_Ksp.simularium
  6. you should see a warning
github-actions[bot] commented 3 months ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
66.26% (-0.07% 🔻)
 644/972
🟡 Branches 65.73% 94/143
🔴 Functions 35.1% 86/245
🟡 Lines
64.65% (-0.07% 🔻)
 576/891
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :-------------------------------------------------------------- | :------------------------------------------------------------- | :------- | :-------- | :------------------------------------------------------------- | | 🔴 |
`...` / logics.ts
|
15.86% (-0.07% 🔻)
| 0% | 0% |
16.22% (-0.07% 🔻)
|

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 3b9cfae8beaff30bb23e5a321f0e7c67e9255102