search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
6 stars 3 forks source link

remove title from embed view #540

Closed meganrm closed 4 weeks ago

meganrm commented 4 weeks ago

Time estimate or Size

xsmall

Problem

What is the problem this work solves, including closes #538

Solution

removed the title from the overlay I did leave a props object there, I can delete it, but I think we are going to have some overlay buttons in the embed view

Type of change

Please delete options that are not relevant.

Steps to Verify:

  1. npm start
  2. go to http://localhost:9001/embed?trajFileName=medyan_Chandrasekaran_2019_UNI_alphaA_0.1_MA_0.675.simularium
  3. no title should be showing

Screenshots (optional):

Screenshot 2024-06-25 at 11 24 21 AM
github-actions[bot] commented 4 weeks ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
66.32% (+0.07% 🔼)
 644/971
🟡 Branches 65.73% 94/143
🔴 Functions 35.1% 86/245
🟡 Lines
64.72% (+0.07% 🔼)
 576/890

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from e794e7e01c6fff6345f9bb15e4bf3fd2f9bc7fff