Closed interim17 closed 2 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 66.73% (+0.51% 🔼) |
666/998 |
🟡 | Branches | 66.21% (+0.47% 🔼) |
96/145 |
🔴 | Functions | 35.83% (+1.03% 🔼) |
91/254 |
🟡 | Lines | 64.98% (+0.43% 🔼) |
592/911 |
121 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 8ef4fe1ad11b73014e27dca23eba2c2305dbf79d
Time estimate or Size
medium
Problem
Closes #146
This is the MVP feature, forthcoming work to be prioritized includes options to adjust what controls are visible, autoplay, default to looping, and addressing visual/UX concerns in the embedded page.
Solution
Update the
ShareTrajectoryModal
to generate an iframe that with a link to the embedded viewer, merged a set of updates by @meganrm that improved organization and design, notably pulling the code for the embed snippet into its own component.Added
VerticalFlexbox
: small reusable component that makes the JSX more readable and prevents having lots of very similar divs each with their own class name on the stylesheet. I think we can add a few more similar container utils over time and do some refactoring to clean up other components.Type of change
Steps to Verify:
allowfullscreen
toallowFullScreen
Screenshots: