search

simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
7 stars 3 forks source link

proposed changes to share-embed #549

Closed meganrm closed 2 months ago

meganrm commented 2 months ago

reasons for changes:

  1. there seemed to be a lot of extra things stored in state (radio button state, trajectory url, last time etc), reduced it to minimal needed
  2. I had trouble following what was happening because of the nested components, state being set halfway down the file (typically states should be set at the top of the component for readability) => extracted out embed snippet to it's own component
  3. Check with Lyndsay, but it seems like you should just be able to click into the time box, instead of having to first click the radio button and then editing the time
  4. constrain proportions was implemented incorrectly
  5. it seemed that the embed snippet should include the time change too since that's at the top of the modal