simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
7 stars 3 forks source link

Feature/user colors #584

Closed interim17 closed 1 month ago

interim17 commented 1 month ago

Time estimate or Size

small

Problem

Closes #579, advances #511

We need to differentiate between the default UI data derived by parsing trajectories and the current UI data that includes user color selections. This PR adds selectedUIDisplayData to redux, and points the getSelectionStateInfoForViewer selector at it. When default arrives it sets the initial state for selected, and then as users make color changes we only update the selected data, and the default remains unchanged.

Steps to Verify:

  1. Nothing should be functionally changed, loading trajectories and changing colors should work as before.
github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
66.34% (-0.2% πŸ”»)
674/1016
🟑 Branches 65.31% 96/147
πŸ”΄ Functions
35% (-0.29% πŸ”»)
91/260
🟑 Lines
64.72% (-0.23% πŸ”»)
600/927
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------- | :------------------------------------------------------------- | :------- | :-------- | :------------------------------------------------------------- | | πŸ”΄ |
`...` / reducer.ts
|
20% (-1.74% πŸ”»)
| 100% | 0% |
20% (-1.74% πŸ”»)
| | πŸ”΄ |
`...` / actions.ts
|
52.17% (-0.21% πŸ”»)
| 100% | 0% |
52.17% (-0.21% πŸ”»)
|

Test suite run success

121 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from c52e95debcae432d9f3c31c951c160dccb8c7980