Closed interim17 closed 1 week ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 67.33% (+0.41% πΌ) |
709/1053 |
π‘ | Branches | 67.52% (+0.42% πΌ) |
106/157 |
π΄ | Functions | 35.98% (+0.49% πΌ) |
95/264 |
π‘ | Lines | 65.73% (+0.43% πΌ) |
631/960 |
132 tests passing in 8 suites.
Report generated by π§ͺjest coverage report action from 622b3b37464649225cfb7afe3e1685a5e044234a
Time estimate or Size
small/medium Changes related to directory organization, connected to #607, will not merge to main until both PRs are approved
Problem
Advances #511
Solution
@frasercl raised some interesting concerns about state branches in a previous PR
We have redux selectors in
/state
that are:ModelPanel
,ViewerPanel
, etc.)Now adding
compoundSelectors
to/state
to account for selectors that consume state from multiple branches and are used multiple containers.This resolution keeps the actual data for
defaultUIDisplayData
in thetrajectory
branch andselectedUIDisplayData
andColorSettings
in theselection
branch, and avoids circular dependencies when the branches try to import each other's selectors.This work is essentially part of #607, but so many lines of moving/organizing code was obscuring the readability of that PR. I will not merge either PR until both are approved. It is a non-breaking change, the app should run as before.
getCurrentUIData
The selector which pulls from multiple branches to determine the current color settings for the app, and to pass to the viewer.
getUiDisplayDataTree
Previously in
trajectory
moved toModelPanel
as it depends on a compound selector, and is only used in once place, could also be incompoundSelectors
folder...