Closed interim17 closed 1 week ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 66.86% (+0.1% 🔼) |
682/1020 |
🟡 | Branches | 66.89% (+0.23% 🔼) |
99/148 |
🔴 | Functions | 34.75% (-0.5% 🔻) |
90/259 |
🟡 | Lines | 64.85% (-0.26% 🔻) |
607/936 |
127 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from ee6d0d754c57290567299a88eec7cc3675ed05d7
Time estimate or Size
small, but sensitive
lockfile is making the line count crazy
Problem
Advances #601 and closes #604
Solution
Installing
antd v5
led to a cascade of other dependency/build questions, and a variety of small fixes to make local and CI/CD type checks, tests, and linters happy.webpack.config.json
to matchantd 5
by removing code for loadingless
variablestsconfig.base.json
andtsconfig.commonjs.json
intotsconfig.json
, I don't see where the commonJS config is being used, am I missing something?.babelrc
to fit what docs suggestbindAll
function and tests, probably used when we had more class based components?Pointing into a feature branch. Lots of styling is broken by this change the App does not look good, but it should run, and the CI/CD should run, and the tests should pass. Addressing styling and getting into the meat of migrating antd 4-> 5 is out of scope, see #601 .